fix(angular): item styling when control has value #24932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averyjohnston
approved these changes
Mar 14, 2022
liamdebeasi
suggested changes
Mar 14, 2022
angular/src/directives/control-value-accessors/value-accessor.ts
Outdated
Show resolved
Hide resolved
sean-perkins
force-pushed
the
FW-154-alt
branch
from
84357bd to
8de4788
Compare
liamdebeasi
approved these changes
Mar 16, 2022
Contributor
|
Prior to merging, please provide the developers on #23809 with a dev build. I'd prefer to have some developer feedback before we ship this. |
Contributor
|
@sean-perkins We can probably merge this now. We've given developers time to test, and this new approach seems safer than the previous approach. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When a control, inside an
ion-itemis displayed within a modal; after opening, closing and re-opening the modal, theitem-has-valueclass is not applied to theion-itemthat wraps the control.Issue URL: #23809
What is the new behavior?
item-has-valueis manually applied to theion-itemfrom the control value accessor, when applying other Ionic classesDoes this introduce a breaking change?
Other information
This PR does misc clean-up to deprecated
substrand usage for add/remove classes.Closing #24401 in favor of this PR.